Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Fvar variability measure for light curves #798
I left some inline comments.
Let me know if you have any questions or when it's ready for final review.
@cnachi - Do you have time to finish this up?
It's always best to try and get pull requests in quickly, otherwise it's usually hard to re-start and there's merge conflicts if others touched the file etc.
@cnachi - Do you have time to finish this up? Or should I just do it?
I think we discussed it and it was mostly a matter of improving the docstring and a little bit the method (e.g.
@cnachi - No, I don't see a formula in the docstring.
Each pull request has three "views" you / I / anyone can choose at the top:
You could check the local commits using
And yes, please after adressing some comments and pushing new commits on a PR, please leave another comment an status, i.e. whether you think the PR is ready or if you have some question, so that I know what to do.
@cnachi - Thank you!
I've cleaned up the docstring and implementation a bit in 9d9be3b and then merged this.
changed the title from
Add Fvar Function with Test to LightCurve
Add Fvar variability measure for light curves
Dec 20, 2016
It should appear here: http://docs.gammapy.org/en/latest/api/gammapy.time.LightCurve.html
It doesn't at the moment because of a docs build issue: http://readthedocs.org/projects/gammapy/builds/4812909/
I'll investigate and fix in the coming days.
@cnachi - just FYI: the online docs build issue has been resolved in the meantime.
Docs for the new method now are here: