New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old flux point classes #814

Merged
merged 7 commits into from Dec 12, 2016

Conversation

Projects
None yet
3 participants
@adonath
Member

adonath commented Dec 10, 2016

This PR removes the old DifferentialFluxPoints and IntegralFluxPoints classes, from the gammapy.spectrum module, tests and docs and all uses of it.

@joleroi @cdeil There's a SpectrumFit.compute_fluxpoints() method which seems to never have worked. I added raise NotImplementedError let me know, if I should remove it completely

@adonath adonath added the cleanup label Dec 10, 2016

@adonath adonath added this to the 0.6 milestone Dec 10, 2016

@adonath adonath self-assigned this Dec 10, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Dec 10, 2016

Member

🎉 , thanks for the cleanup!

I don't remember if I was involved with adding SpectrumFit.compute_fluxpoints or if it's something @joleroi did:
https://github.com/gammapy/gammapy/blame/080a1498d6e390b6d4a7feabafb6f2a71b28f4aa/gammapy/spectrum/fit.py#L225

I'll add @joleroi as reviewer now.
But @adonath - if you want to merge this now, no worries, we can always bring stuff back from version history.

Member

cdeil commented Dec 10, 2016

🎉 , thanks for the cleanup!

I don't remember if I was involved with adding SpectrumFit.compute_fluxpoints or if it's something @joleroi did:
https://github.com/gammapy/gammapy/blame/080a1498d6e390b6d4a7feabafb6f2a71b28f4aa/gammapy/spectrum/fit.py#L225

I'll add @joleroi as reviewer now.
But @adonath - if you want to merge this now, no worries, we can always bring stuff back from version history.

@cdeil cdeil requested a review from joleroi Dec 10, 2016

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Dec 10, 2016

Member

@joleroi Could you please update this notebook to use FluxPoints instead of DifferentialFluxPoints? Once the change is done Travis-CI should pass...Thanks!

Member

adonath commented Dec 10, 2016

@joleroi Could you please update this notebook to use FluxPoints instead of DifferentialFluxPoints? Once the change is done Travis-CI should pass...Thanks!

@joleroi

joleroi approved these changes Dec 12, 2016 edited

@adonath and I fixed the remaining issues, all looks fine now. Let's see if tests pass ...

@adonath adonath merged commit 775705b into gammapy:master Dec 12, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Dec 12, 2016

Member

Thanks @joleroi!

Member

adonath commented Dec 12, 2016

Thanks @joleroi!

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Dec 12, 2016

Contributor

+65 -265
itwasagoodday

Contributor

joleroi commented Dec 12, 2016

+65 -265
itwasagoodday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment