New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add morphology models for gamma-cat sources #820

Merged
merged 2 commits into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Dec 14, 2016

This PR adds a morphology_model method to SourceCatalogObjectGammaCat

@adonath adonath self-assigned this Dec 14, 2016

@adonath adonath added the feature label Dec 14, 2016

@cdeil cdeil added this to the 0.6 milestone Dec 14, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Dec 14, 2016

Member

Thanks! Merge now?
(there's no test, so no need to wait for travis-ci, right?)

Member

cdeil commented Dec 14, 2016

Thanks! Merge now?
(there's no test, so no need to wait for travis-ci, right?)

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Dec 14, 2016

Member

I'm merging this now.

Thanks!

Travis-ci fails are due to the rename paper_id -> reference_id in gamma-cat that I did earlier today. We really need to implement versioning for gamma-cat to decouple the projects, but I don't have time today.

Member

cdeil commented Dec 14, 2016

I'm merging this now.

Thanks!

Travis-ci fails are due to the rename paper_id -> reference_id in gamma-cat that I did earlier today. We really need to implement versioning for gamma-cat to decouple the projects, but I don't have time today.

@cdeil cdeil merged commit d421735 into gammapy:master Dec 14, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Dec 14, 2016

Member

Small follow-up commit in master for gammacat: 9ee2748

Member

cdeil commented Dec 14, 2016

Small follow-up commit in master for gammacat: 9ee2748

@cdeil cdeil changed the title from Add morphology method to gammacat to Add morphology models for gamma-cat sources Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment