Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gammapy.utils.modeling and GammaCat to XML #830

merged 1 commit into from Dec 21, 2016


Copy link

@cdeil cdeil commented Dec 21, 2016

This pull request adds gammapy.utils.modeling, a set of classes to represent parameters and models and perform XML model I/O.

This is just a prototype, not exposed in the docs at the moment. The goal was to be able to save gamma-cat in XML format for the CTA data challenge GPS sky model.

I will merge this now without review.

I think this is a good starting point for further work on models.
Some thoughts / tasks are listed at the top of gammapy/utils/

cc @adonath @robertazanin - You will have to update to the latest version of Gammapy so that ./ skymodels xml in the cta-dc repo works again. I removed the version of this code I had commited in ctadc/extern earlier today, so that we don't get confused with code to work on.

@robertazanin - Let me know if something isn't working or you need something implemented short-term. Otherwise @adonath and I will continue with model and catalog code in Gammapy and data entry in gamma-cat and in ~ mid January there will be something very nice.

@cdeil cdeil added the feature label Dec 21, 2016
@cdeil cdeil added this to the 0.6 milestone Dec 21, 2016
@cdeil cdeil self-assigned this Dec 21, 2016
@cdeil cdeil merged commit 216946b into gammapy:master Dec 21, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant