New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTA Sensitivity class and plot improvements #831

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@jjlk
Contributor

jjlk commented Dec 29, 2016

Hi @cdeil ,
Following this PR, gammapy/gammapy-extra#48, I added a class to handle the CTA sensitivity and I improved the plots. I modified the existing test accordingly.
Oké to merge?
Thanks

@cdeil cdeil self-assigned this Jan 6, 2017

@cdeil cdeil added the feature label Jan 6, 2017

@cdeil cdeil added this to the 0.6 milestone Jan 6, 2017

@cdeil cdeil referenced this pull request Jan 6, 2017

Merged

Improve NDDataArray (use composition, not inheritance) #832

5 of 5 tasks complete
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jan 6, 2017

Member

I'm merging this now, thanks!

Currently SensitivityTable sub-classes NDDataArray, which @joleroi is re-writing in #832 .
I don't know if using NDDataArray here is / will be a good idea.

@jjlk - In the future, please include at least one high-level test that exercises the main functionality. Without that, it becomes hard for us (in this case @joleroi in #832) to re-factor code, because it's not clear what the core functionality is that should be preserved. I presume in this case it's for now just to be able to read the file and call plot?

Member

cdeil commented Jan 6, 2017

I'm merging this now, thanks!

Currently SensitivityTable sub-classes NDDataArray, which @joleroi is re-writing in #832 .
I don't know if using NDDataArray here is / will be a good idea.

@jjlk - In the future, please include at least one high-level test that exercises the main functionality. Without that, it becomes hard for us (in this case @joleroi in #832) to re-factor code, because it's not clear what the core functionality is that should be preserved. I presume in this case it's for now just to be able to read the file and call plot?

@cdeil cdeil merged commit a8bdda3 into gammapy:master Jan 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jjlk

This comment has been minimized.

Show comment
Hide comment
@jjlk

jjlk Jan 8, 2017

Contributor

Currently SensitivityTable sub-classes NDDataArray, which @joleroi is re-writing in #832 .
I don't know if using NDDataArray here is / will be a good idea.

I'll adapt the classes (bkg, psf and sensitivity) when @joleroi's developments will be done.

@jjlk - In the future, please include at least one high-level test that exercises the main functionality. Without that, it becomes hard for us (in this case @joleroi in #832) to re-factor code, because it's not clear what the core functionality is that should be preserved.

Understood.

I presume in this case it's for now just to be able to read the file and call plot?

Yes. Thanks ++

Contributor

jjlk commented Jan 8, 2017

Currently SensitivityTable sub-classes NDDataArray, which @joleroi is re-writing in #832 .
I don't know if using NDDataArray here is / will be a good idea.

I'll adapt the classes (bkg, psf and sensitivity) when @joleroi's developments will be done.

@jjlk - In the future, please include at least one high-level test that exercises the main functionality. Without that, it becomes hard for us (in this case @joleroi in #832) to re-factor code, because it's not clear what the core functionality is that should be preserved.

Understood.

I presume in this case it's for now just to be able to read the file and call plot?

Yes. Thanks ++

@jjlk jjlk deleted the jjlk:cta_perf branch Jan 8, 2017

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Jan 9, 2017

Contributor

I'll adapt the classes (bkg, psf and sensitivity) when @joleroi's developments will be done.

This is done in #832, so you don't have to worry. You might need to update some of your personal scripts

Contributor

joleroi commented Jan 9, 2017

I'll adapt the classes (bkg, psf and sensitivity) when @joleroi's developments will be done.

This is done in #832, so you don't have to worry. You might need to update some of your personal scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment