Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spectrum observation write issue #836

Merged

Conversation

@JouvinLea
Copy link

@JouvinLea JouvinLea commented Jan 10, 2017

There was an issue in the method writeof the class SpectrumObservation. The option use_sherpa was not tested and with the modification you did for the type of area.data or edisp.data it was not working anymore.
I fix the issue and add a test for use_sherpa=True

@cdeil cdeil added the bug label Jan 10, 2017
@cdeil cdeil added this to the 0.6 milestone Jan 10, 2017
@cdeil cdeil requested a review from joleroi Jan 10, 2017
@cdeil cdeil changed the title fix issue with the option use_sherpa for writting ogip files Fix SpectrumObservation write bug Jan 10, 2017
Copy link
Contributor

@joleroi joleroi left a comment

Thanks for spotting & fixing this. The test could be improved by using pytest.parametrize but this is no blocker.

@JouvinLea
Copy link
Author

@JouvinLea JouvinLea commented Jan 10, 2017

@cdeil @joleroi
All the tests passed, can we merge?

@joleroi joleroi merged commit 1a5696b into gammapy:master Jan 10, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi joleroi changed the title Fix SpectrumObservation write bug Fix bug in SpectrumObservation.write(use_sherpa=True) Jan 10, 2017
@cdeil cdeil changed the title Fix bug in SpectrumObservation.write(use_sherpa=True) Fix spectrum observation write issue Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants