Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix energy binning issue in cube pipe #840

Merged
merged 1 commit into from Jan 17, 2017
Merged

Conversation

@JouvinLea
Copy link

@JouvinLea JouvinLea commented Jan 17, 2017

There was an issue in the code of cube_pipe when I was calling the method energies() of a SkyCube. I forgot to specify mode="edges" so the last bin in energy for the background was always zero...
Sorry for the mistake

@cdeil cdeil self-assigned this Jan 17, 2017
@cdeil cdeil added the bug label Jan 17, 2017
@cdeil cdeil added this to the 0.6 milestone Jan 17, 2017
@cdeil
cdeil approved these changes Jan 17, 2017
Copy link
Member

@cdeil cdeil left a comment

Looks good to me. Let's wait for travis-ci to pass.

@cdeil cdeil merged commit 8322b7a into gammapy:master Jan 17, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdeil cdeil changed the title Fix an issue with the energies binning in Cube_pipe Fix energy binning issue in cube pipe Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants