Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background model component to SpectrumFit #845

Merged
merged 7 commits into from Feb 6, 2017

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Jan 23, 2017

This PR

  • Allows a background model to be passed to SpectrumFit. If a cash fit is performed it is added to the fit model
  • Add the possibility to calculate & plot likelihood profiles to SpectrumFit

Does NOT

  • Add a Parameter class, the code as it is contains many hacks, but I wanted to keep the diff small. I will start a follow-up PR now

No need to review

@joleroi joleroi force-pushed the joleroi:bkg_model_fit branch from 5069ea6 to 6adb06e Jan 24, 2017
@joleroi joleroi force-pushed the joleroi:bkg_model_fit branch from e94d5bb to a8dac2b Feb 3, 2017
@cdeil cdeil modified the milestone: 0.6 Feb 5, 2017
@joleroi joleroi force-pushed the joleroi:bkg_model_fit branch from a3c44c1 to 3771e94 Feb 6, 2017
@joleroi joleroi modified the milestones: 0.7, 0.6 Feb 6, 2017
@joleroi joleroi changed the title WIP: add background model to SpectrumFit Add background model component to SpectrumFit Feb 6, 2017
@joleroi joleroi merged commit 24999f6 into gammapy:master Feb 6, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi joleroi deleted the joleroi:bkg_model_fit branch Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants