New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background model component to SpectrumFit #845

merged 7 commits into from Feb 6, 2017


None yet
2 participants

joleroi commented Jan 23, 2017

This PR

  • Allows a background model to be passed to SpectrumFit. If a cash fit is performed it is added to the fit model
  • Add the possibility to calculate & plot likelihood profiles to SpectrumFit

Does NOT

  • Add a Parameter class, the code as it is contains many hacks, but I wanted to keep the diff small. I will start a follow-up PR now

No need to review

@joleroi joleroi added the feature label Jan 23, 2017

@cdeil cdeil modified the milestone: 0.6 Feb 5, 2017

@joleroi joleroi modified the milestones: 0.7, 0.6 Feb 6, 2017

@joleroi joleroi changed the title from WIP: add background model to SpectrumFit to Add background model component to SpectrumFit Feb 6, 2017

@joleroi joleroi merged commit 24999f6 into gammapy:master Feb 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@joleroi joleroi deleted the joleroi:bkg_model_fit branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment