New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fermi basic image estimator #865

Merged
merged 5 commits into from Feb 2, 2017

Conversation

Projects
None yet
3 participants
@adonath
Member

adonath commented Feb 1, 2017

This PR adds a FermiLATBasicImageEstimator class , which allows to compute a set of basic sky images for any given reference region. basic sky images may contain counts, background, exposure, flux, excess and psf. Where psf is just a SkyImage containing an image of the PSF.

@adonath adonath added the feature label Feb 1, 2017

@adonath adonath added this to the 0.6 milestone Feb 1, 2017

@adonath adonath self-assigned this Feb 1, 2017

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Feb 1, 2017

Contributor

Nice!

Contributor

joleroi commented Feb 1, 2017

Nice!

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Feb 1, 2017

Member

Looks great!
My only comment is: please try to set some time aside for making docs examples before the workshops and stop adding features at some point. :-)

Member

cdeil commented Feb 1, 2017

Looks great!
My only comment is: please try to set some time aside for making docs examples before the workshops and stop adding features at some point. :-)

@adonath adonath merged commit 25326d0 into gammapy:master Feb 2, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Feb 2, 2017

Member

@joleroi @cdeil Thanks! Yes, the next step is to make the prepared Fermi-LAT datasets available and provide more examples in the docs and an example notebook.

Member

adonath commented Feb 2, 2017

@joleroi @cdeil Thanks! Yes, the next step is to make the prepared Fermi-LAT datasets available and provide more examples in the docs and an example notebook.

@adonath adonath deleted the adonath:fermi_basic_image_estimator branch Feb 2, 2017

@cdeil cdeil changed the title from Fermi basic image estimator to Add Fermi basic image estimator Feb 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment