New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SED type e2dnde to FluxPoints #872

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@joleroi
Contributor

joleroi commented Feb 7, 2017

Add SED type e2dnde to FluxPoints

@joleroi joleroi added the feature label Feb 7, 2017

@cdeil cdeil added this to the 0.6 milestone Feb 7, 2017

@cdeil cdeil requested a review from adonath Feb 7, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Feb 7, 2017

Member

There were a few discussions on this in the issue tracker for the spectral points formats.

If I remember correctly, Matthew was against adding this, but somehow I convinced him that it's OK to add e2dnde as a separate "type" to the spec, and it's here now:
http://gamma-astro-data-formats.readthedocs.io/en/latest/results/flux_points/index.html#sed-types

I think my main point was that sometimes e2dnde is published and thus useful to have a format for, i.e. to agree on column names to store it. Now that doesn't mean we have to add this type to the Gammapy class, but probably it's the easiest way to handle this.

@adonath - assigning to you.

Member

cdeil commented Feb 7, 2017

There were a few discussions on this in the issue tracker for the spectral points formats.

If I remember correctly, Matthew was against adding this, but somehow I convinced him that it's OK to add e2dnde as a separate "type" to the spec, and it's here now:
http://gamma-astro-data-formats.readthedocs.io/en/latest/results/flux_points/index.html#sed-types

I think my main point was that sometimes e2dnde is published and thus useful to have a format for, i.e. to agree on column names to store it. Now that doesn't mean we have to add this type to the Gammapy class, but probably it's the easiest way to handle this.

@adonath - assigning to you.

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Feb 8, 2017

Contributor

@adonath As discussed offline I changed the default marker to '+'. To prevent people from getting an empty plot if there are no error bars

Contributor

joleroi commented Feb 8, 2017

@adonath As discussed offline I changed the default marker to '+'. To prevent people from getting an empty plot if there are no error bars

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Feb 8, 2017

Contributor
Contributor

joleroi commented Feb 8, 2017

@joleroi joleroi merged commit 5e0cd91 into gammapy:master Feb 8, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@joleroi joleroi deleted the joleroi:update_flux_points branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment