New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BinnedDataAxis handling of lo / hi binning #884

Merged
merged 4 commits into from Feb 14, 2017

Conversation

Projects
None yet
2 participants
@joleroi
Contributor

joleroi commented Feb 10, 2017

This PR updates ~gammapy.utils.nddata.BinnedDataAxis to reflect the data format typically encountered in IRF files, namely the specification of bin_lo and bin_hi.

Fixes #861

@joleroi joleroi added the cleanup label Feb 10, 2017

@joleroi joleroi added this to the 0.6 milestone Feb 10, 2017

@joleroi joleroi self-assigned this Feb 10, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Feb 12, 2017

Member

Maybe just merge and fix up issues as they turn up in master?

Member

cdeil commented Feb 12, 2017

Maybe just merge and fix up issues as they turn up in master?

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Feb 13, 2017

Contributor

👎 because, many IRFs classes are just broken at the moment and it's straightforward to fix them.

Contributor

joleroi commented Feb 13, 2017

👎 because, many IRFs classes are just broken at the moment and it's straightforward to fix them.

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Feb 14, 2017

Contributor

Remaing issues are due to GammaCatNotFound errors. Test should be decorated I guess ...
Merging

Contributor

joleroi commented Feb 14, 2017

Remaing issues are due to GammaCatNotFound errors. Test should be decorated I guess ...
Merging

@joleroi joleroi merged commit 0e3a282 into gammapy:master Feb 14, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@joleroi joleroi deleted the joleroi:rework_binneddataaxis branch Feb 14, 2017

@cdeil cdeil changed the title from Update BinnedDataAxis to accept bin_lo and bin_hi on input to Improve BinnedDataAxis handling of lo / hi binning Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment