New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CTA IRF and simulation classes (point-like analysis) #888

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@jjlk
Contributor

jjlk commented Feb 15, 2017

Hi @cdeil,

This PR:

  • adapt the CTAPerf class to the new BinnedDataAxis class. Add rmf as attribute.
  • add a minimal test for CTAPerf
  • rename CTASpectrumObservation to CTASimulationObservation
  • use static methods
  • simplify the ObservationParameters class
  • add minimal tests for each classes of cta_utils.py

I need that for the gammapy meeting next week. I'll merge that in a bit if you are not available (all tests should work when gammapy/gammapy-extra#52 will be merged)

This PR does not change the fact that CTASimulationObservation should be merge with SpectrumSimulation in a near future.

Output example for the extrapolation of a Fermi/LAT source is shown below (~0.015 s for a simulation, it's ultra fast!).

example_simu

Adapt CTAPerf to new BinnedDataAxis class. Add test also(with new ver…
…sion of IRF on gammapy-extra). Adapt cta_utils.py to new BinnedDataAxis class and rename simulation class. Add test

@jjlk jjlk merged commit 0b1c123 into gammapy:master Feb 15, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@cdeil cdeil added this to the 0.6 milestone Feb 15, 2017

@cdeil cdeil changed the title from Adapt CTAPerf and CTA simulations (point-like analysis) to Improve CTA IRF and simulation classes (point-like analysis) Feb 18, 2017

@jjlk jjlk deleted the jjlk:cta_simu branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment