New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Double plot issue in notebooks and improve events.peek() #919

Merged
merged 2 commits into from Feb 24, 2017

Conversation

Projects
None yet
3 participants
@facero
Contributor

facero commented Feb 24, 2017

changing peek() to show image in RA/DEC and event rate vs time.
Fixed the double plot issue in jupyter for all the peek functions.
Double plot was due to return fig in plot routine.
In peek routine the plt.plot() was showing the figure then the peek() function was returning a fig object. If .peek() was the last line of the notebook cell then the fig object was displayed by Jupyter therefore showing the figure twice.

facero added some commits Feb 22, 2017

fixing double plot issue in Jupyter
commenting the plt.show() and return fig in peek() functions to avoid
double plots in jupyter notebook

@cdeil cdeil self-assigned this Feb 24, 2017

@cdeil cdeil added the bug label Feb 24, 2017

@cdeil cdeil added this to the 0.6 milestone Feb 24, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Feb 24, 2017

Member

Thanks!
I'm merging this now.
I'll do a follow-up cleanup commit in master.

Member

cdeil commented Feb 24, 2017

Thanks!
I'm merging this now.
I'll do a follow-up cleanup commit in master.

@cdeil cdeil merged commit a684b0c into gammapy:master Feb 24, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Feb 24, 2017

Member

This is the follow-up commit I did: 550bba7
Notebook double-plotting issue should be resolved now.

Everyone can check for the notebooks they work on, or I'll check in the next days.

Member

cdeil commented Feb 24, 2017

This is the follow-up commit I did: 550bba7
Notebook double-plotting issue should be resolved now.

Everyone can check for the notebooks they work on, or I'll check in the next days.

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Feb 24, 2017

Contributor

It has gone away for spectrum_analysis.ipynb. Awesome thanks @facero !

Contributor

joleroi commented Feb 24, 2017

It has gone away for spectrum_analysis.ipynb. Awesome thanks @facero !

@cdeil cdeil changed the title from Double plot issue in Jupyter and changing the events.peek() function. to Fix Double plot issue in notebooks and improve events.peek() Apr 28, 2017

@facero facero deleted the facero:plot_peek branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment