Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NDDataArray default_interp_kwargs to extrapolate #932

Merged
merged 2 commits into from Mar 3, 2017

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Mar 3, 2017

Fixes #913
Related: gammasky/cta-dc@cb36f93

@joleroi joleroi added the feature label Mar 3, 2017
@joleroi joleroi added this to the 0.6 milestone Mar 3, 2017
@joleroi joleroi self-assigned this Mar 3, 2017
@joleroi
Copy link
Contributor Author

@joleroi joleroi commented Mar 3, 2017

This solves the 0 offset problem for EffectiveArea2d and EnergyDipsersion2d. That the only places where the NDData array is used I don't know what the PSF classes do.

Loading

@joleroi
Copy link
Contributor Author

@joleroi joleroi commented Mar 3, 2017

I updated the test values #Likeintheolddays

Loading

@joleroi joleroi merged commit 61c9883 into gammapy:master Mar 3, 2017
0 of 2 checks passed
Loading
@joleroi joleroi deleted the interpolation branch Mar 3, 2017
@cdeil cdeil changed the title Fix 913 Change NDDataArray default_interp_kwargs to extrapolate Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant