New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NDDataArray default_interp_kwargs to extrapolate #932

Merged
merged 2 commits into from Mar 3, 2017

Conversation

Projects
None yet
1 participant
@joleroi
Contributor

joleroi commented Mar 3, 2017

Fixes #913
Related: gammasky/cta-dc@cb36f93

@joleroi joleroi added the feature label Mar 3, 2017

@joleroi joleroi added this to the 0.6 milestone Mar 3, 2017

@joleroi joleroi self-assigned this Mar 3, 2017

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Mar 3, 2017

Contributor

This solves the 0 offset problem for EffectiveArea2d and EnergyDipsersion2d. That the only places where the NDData array is used I don't know what the PSF classes do.

Contributor

joleroi commented Mar 3, 2017

This solves the 0 offset problem for EffectiveArea2d and EnergyDipsersion2d. That the only places where the NDData array is used I don't know what the PSF classes do.

joleroi added some commits Mar 3, 2017

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Mar 3, 2017

Contributor

I updated the test values #Likeintheolddays

Contributor

joleroi commented Mar 3, 2017

I updated the test values #Likeintheolddays

@joleroi joleroi merged commit 61c9883 into gammapy:master Mar 3, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@joleroi joleroi deleted the joleroi:interpolation branch Mar 3, 2017

@cdeil cdeil changed the title from Fix 913 to Change NDDataArray default_interp_kwargs to extrapolate Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment