New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wstat likelihood function for spectra and images #96

Merged
merged 1 commit into from May 23, 2014

Conversation

Projects
None yet
3 participants
@registerrier
Contributor

registerrier commented Mar 5, 2014

This PR adds the wstat likelihood function (a.k.a. "on-off-likelihood') for spectrum and image fitting with Sherpa.

This is currently in the dev/sherpa/ folder ... tests and docs have to be added in a future PR.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Mar 16, 2014

Member

@registerrier Can you add example scripts that use these classes?
It doesn't matter if they use files we don't have ... I can write a script to fake some data or include a small dataset from Fermi LAT.

Member

cdeil commented Mar 16, 2014

@registerrier Can you add example scripts that use these classes?
It doesn't matter if they use files we don't have ... I can write a script to fake some data or include a small dataset from Fermi LAT.

@cdeil cdeil added the feature label Apr 11, 2014

@cdeil cdeil added this to the 0.2 milestone Apr 11, 2014

@cdeil cdeil assigned ellisowen and unassigned registerrier and ellisowen May 2, 2014

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 21, 2014

Member

@registerrier Will you have time to add an example here by next week?
If no I'll just merge this in as-is, so that it's available in the master branch.

Member

cdeil commented May 21, 2014

@registerrier Will you have time to add an example here by next week?
If no I'll just merge this in as-is, so that it's available in the master branch.

cdeil added a commit that referenced this pull request May 23, 2014

@cdeil cdeil merged commit 8e59025 into gammapy:master May 23, 2014

1 check passed

default The Travis CI build passed
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 23, 2014

Member

I'm merging this now ... let's just make new pull requests for further files or changes.

Member

cdeil commented May 23, 2014

I'm merging this now ... let's just make new pull requests for further files or changes.

@cdeil cdeil modified the milestones: 0.1, 0.2 May 23, 2014

@cdeil cdeil changed the title from add 1d and 2D wstat to Add wstat likelihood function for spectra and images Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment