Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add flux point fitter class #979
@adonath - Thanks!
I've left some inline comments.
Concerning your task list:
Rework flux point upper limit handling
Can you merge this ASAP and defer that to the future?
For now, how about adding a two-line
FluxPoints.drop_ul classmethod and in the fitter to assume it's all non-UL?
Improve test (add asserts on more values of the result dict)
Yes, please add asserts on the other numbers in the results dict and the parameter errors.
And can you expose the Sherpa result objects? I.e. give people access to what Sherpa has built in without needing to re-expose a different set of results.
Wait for #978 to be merged and rebase
It's unrelated. But I'll merge that within the hour.
The notebook is nice!
Suggest to add an intro at the top what it is, and to also print out the fitted model results.
Why not keep it a bit simpler and use the same flux points for the three spectral models?
Also I think it might be simpler to just pass data and model to the fitter init, and use one fitter per fit and to keep it simple.