cdeil left a comment
@adonath - Thanks!
I've left some inline comments.
Concerning your task list:
Can you merge this ASAP and defer that to the future?
Yes, please add asserts on the other numbers in the results dict and the parameter errors.
And can you expose the Sherpa result objects? I.e. give people access to what Sherpa has built in without needing to re-expose a different set of results.
It's unrelated. But I'll merge that within the hour.
The notebook is nice!
Suggest to add an intro at the top what it is, and to also print out the fitted model results.
Why not keep it a bit simpler and use the same flux points for the three spectral models?
Also I think it might be simpler to just pass data and model to the fitter init, and use one fitter per fit and to keep it simple.