Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect Linux capabilities(7) in cache #6

Closed
wants to merge 1 commit into from

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 10, 2019

The default GNU tar configuration does not carry fancy extended
attributes and that is where, among other things, stuff like Linux
capabilities(7) are stored. This is kind of important because that's
how ping(8) works for regular users.

We shove --selinux and --acls in there while we're at it, because why
not. We never know what the future might bring, and it seems
silly not to create a complete archive.

Note that --xattrs-include='*' is important because, by default, GNU
tar will not include capabilities /even/ if --xattrs is specified on
the commandline, see this bug report for details:

https://bugzilla.redhat.com/show_bug.cgi?id=771927

The default GNU tar configuration does not carry fancy extended
attributes and that is where, among other things, stuff like Linux
capabilities(7) are stored. This is kind of important because that's
how ping(8) works for regular users.

We shove --selinux and --acls in there while we're at it, because why
not. We never know what the future might bring, and it seems
silly *not* to create a complete archive.

Note that --xattrs-include='*' is important because, by default, GNU
tar will not include capabilities /even/ if --xattrs is specified on
the commandline, see this bug report for details:

https://bugzilla.redhat.com/show_bug.cgi?id=771927
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@anarcat
Copy link
Contributor Author

anarcat commented Oct 10, 2019

i do not have or wish to have a google account, but do whatever with my code already and just fix this bug. ktxbye.

@anarcat
Copy link
Contributor Author

anarcat commented Dec 11, 2019

ping.

@iustin
Copy link
Contributor

iustin commented Dec 11, 2019

Unfortunately until the split from Google is finalized, we can't merge this without signing the CLA. I'm surprised one need a google account for it though, I thought you can sign with any email address…

@anarcat
Copy link
Contributor Author

anarcat commented Dec 11, 2019

how about i release this in the public domain, CC0, or whatever, and someone else picks it up and commits it?

i regret opening that PR in the first place now :(

@saschalucas
Copy link
Member

@anarcat: i would pick it up and proxy-PR it for you. I totally understand to reject singing CLAs. THX Sascha.

@saschalucas
Copy link
Member

I've proxy-PRed this PR in #7. probably this can be closed? thanks sascha.

@anarcat anarcat closed this Dec 12, 2019
@anarcat anarcat deleted the caps branch December 12, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants