New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the option to remove unnecessary XML data #240

Merged
merged 1 commit into from Aug 3, 2014

Conversation

Projects
None yet
2 participants
@cddude229
Contributor

cddude229 commented Jun 3, 2014

The EXTRA_DATA and EXTRA_ELEMENT data returned by Ganglia is unused in many code paths, so by stripping it we can see XML parsing performance gains of about 50% for large data sets.

In production, gmetad was returning 26MB of XML data for the everything path. By filtering this subset of data out, it took parsing time from an average of 2.1s to 1.1s, a nearly 50% improvement.

By looking at the start_* functions, we can see if they use the EXTRA_DATA information at all. Since most of them don't, we can safely strip out the information.

Provide the option to remove unnecessary XML data.
The EXTRA_DATA and EXTRA_ELEMENT data returned by Ganglia is unused in
many code paths, so by stripping it we can see XML parsing performance
gains of about 50% for large data sets.

vvuksan added a commit that referenced this pull request Aug 3, 2014

Merge pull request #240 from cddude229/optimize-xml-volume
Provide the option to remove unnecessary XML data

@vvuksan vvuksan merged commit 0d17fe3 into ganglia:master Aug 3, 2014

@cddude229 cddude229 deleted the cddude229:optimize-xml-volume branch Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment