From ab3ca92cc8168209d77e8d03c51963452f8f498c Mon Sep 17 00:00:00 2001 From: Benedikt Waldvogel Date: Thu, 23 Feb 2012 14:17:38 +0100 Subject: [PATCH] make use of 'with' statement --- gmetric-mongodb.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/gmetric-mongodb.py b/gmetric-mongodb.py index 48fb194..ff7cad3 100755 --- a/gmetric-mongodb.py +++ b/gmetric-mongodb.py @@ -117,10 +117,9 @@ def ops(self): out = {} cur_ops = self.status["opcounters"] try: - f = open(self.ops_tmp_file, "r") - content = f.read() - prev_ops = json.loads(content) - f.close() + with open(self.ops_tmp_file, "r") as f: + content = f.read() + prev_ops = json.loads(content) except (ValueError, IOError): prev_ops = {} @@ -131,11 +130,8 @@ def ops(self): name = "queries_per_second" out[name] = (max(0, float(v) - float(prev_ops[k])) / 60, "ops/s") - f = open(self.ops_tmp_file, 'w') - try: + with open(self.ops_tmp_file, 'w') as f: f.write(json.dumps(cur_ops)) - finally: - f.close() self.callGmetric(out)