marktoneEnabledの判定方法を修正 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganta
requested changes
May 22, 2020
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "chrome-extension-marktone", | |||
| "version": "1.4.0", | |||
| "version": "1.4.1", | |||
There was a problem hiding this comment.
こちらのバージョンはリリース時にbumpしますので変更しないようお願いします〜
There was a problem hiding this comment.
- package.jsonのコミットを取り消しました！
- コミットメッセージに
fix:のプレフィックスを付けました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marktonの利用可否がfalseのときにdocument.body.dataset.marktoneEnabled が正しく判定されないことで、ピープルの返信時に不要な改行が当たる不具合を修正
不具合内容
marktoneEnabled が false のときに、kintone で「返信」ボタンを押してメンションが挿入されるときに不要なスタイルが当たる（pタグにmargin: 0 0 16pxが当たる）
不具合再現手順