Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing assignments get removed when assigning new items #1501

Closed
AmibeWebsites opened this issue Aug 12, 2016 · 10 comments
Closed

Existing assignments get removed when assigning new items #1501

AmibeWebsites opened this issue Aug 12, 2016 · 10 comments

Comments

@AmibeWebsites
Copy link
Contributor

If you have existing layout assignments and then go and add new assignments, all existing assignments are lost.

@caleb
Copy link

caleb commented Aug 13, 2016

I thought I was going crazy, or that I was selecting mutually exclusive assignments…

@AmibeWebsites
Copy link
Contributor Author

Yes, I noticed it a few weeks ago but thought it was part of another issue I was having with assignments on one particular site. It does cause one to question ones sanity for a brief moment :-D

@mahagr
Copy link
Member

mahagr commented Aug 15, 2016

Sounds like the same issue as in: #1451..?

@mahagr mahagr added this to the 5.3.3 milestone Aug 15, 2016
@AmibeWebsites
Copy link
Contributor Author

Not sure if it's the same but it certainly sounds related - one fix to solve them all?

@mahagr mahagr removed the duplicate label Aug 15, 2016
@mahagr
Copy link
Member

mahagr commented Aug 15, 2016

I removed duplicate tag for now; I also think they may be related. I also need to check if I can reproduce this exact issue. Which platform are you on? Joomla or WP?

@caleb
Copy link

caleb commented Aug 15, 2016

I am on Wordpress (version 4.5.3).

@mahagr mahagr changed the title Assignment Houdini Existing assignments get removed when assigning new items Aug 19, 2016
@mahagr
Copy link
Member

mahagr commented Aug 19, 2016

@w00fz This seems to be issue in javascript when sending data back on save. It only sends data from changed values, not the ones that were already set.

@mahagr
Copy link
Member

mahagr commented Aug 19, 2016

Not sure why this only works in Joomla.

@w00fz
Copy link
Member

w00fz commented Aug 24, 2016

It's not the JavaScript, it's the twig rendering the items that are on as disabled, when the page loads.

@w00fz w00fz closed this as completed in e63f417 Aug 24, 2016
@AmibeWebsites
Copy link
Contributor Author

Wonderful, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants