Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo image max height #2424

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@adiwebdev
Copy link
Contributor

commented Nov 25, 2018

It works with logo images only, as svg size shouldn't be set using width / height. The default value is empty, it won't affect existing websites. I tested with Helium theme.

ref: #2399

adiwebdev added some commits Nov 25, 2018

@mahagr mahagr requested a review from newkind Jan 2, 2019

@mahagr mahagr added the enhancement label Jan 2, 2019

@mahagr

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

@newkind Can you check this out?

@newkind

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Looks good to me. @adiwebdev can I ask you to modify the label in YAML from Image Height to Maxium Height or something like this? Using Image Height can be confusing when your image is actually shorter than the max height value.

@mahagr mahagr merged commit 2cf7c94 into gantry:develop Jan 3, 2019

@mahagr mahagr added this to the 5.4.28 milestone Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.