Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable menu with CSS on mobile devices #2538

Open
wants to merge 1 commit into
base: develop
from

Conversation

@thexmanxyz
Copy link
Contributor

commented Sep 10, 2019

This PR is based on the issue #2536. It adds to the menu particle a checkbox option to completely disable the menu on mobile devices (mobile-only). For further information read the referenced issue which explains why this might be useful for users (flickering).

Hence, this gives the user the option to decide whether he wants to risk ending with no menu on mobile devices when no JS is supported but prevents the main menu to be rendered during page load (which is still an annoying issue for many people). This might be a good compromise because the default behaviour is maintained and there is an option to decide whether the risk should be taken (also explained in the field description).

Note: The SCSS added might not be added on the right spot and / or applied only for Hydrogen. Any input would be helpful I will change the PR properly if I know to do it correctly.

@N8Solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.