Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding feature to uninstall an extension #23

Merged
merged 22 commits into from Jul 22, 2017

Conversation

@NileshGule
Copy link
Contributor

commented Jul 17, 2017

Fixes #14 for MacOSX. The changes have been tested on MacOS. The molecule test hangs while running the role while testing uninstall. I have commented the test to make the build pass. Currently the task for uninstallation is filtered specifically for MacOSX as I am not sure about other OS.

Need help in testing the uninstall feature with other operating systems.

For now these changes have been tested on Mac OS Sierra 10.12.5

@freemanjp freemanjp changed the base branch from master to develop Jul 22, 2017

@freemanjp freemanjp merged commit fc4d7ea into gantsign:develop Jul 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@freemanjp

This comment has been minimized.

Copy link
Member

commented Jul 22, 2017

@NileshGule thanks for you pull request it has been merged and is available in the 1.2.0 release of this role.

The tests were difficult to get right so I'm not surprised they caused you trouble. The feature is now working all OSs; I also fixed a bug where it was failing if you were trying to uninstall a role that wasn't installed (i.e. you can now re-run the role successfully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.