Skip to content

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented Nov 12, 2025

By setting relativePath=../../.. before running makedoc.g

This affects several packages; once we merged this and updated the tags, these packages should get new releases:

By setting relativePath=../../.. before running makedoc.g
@stertooy
Copy link
Contributor

LGTM!

I didn't notice my packages' documentation had links being hardcoded as /home/runner/gap/pkg/.... Whoops.

Was a bit afraid this might interfere with the URL substitution here in update-gh-pages, but that doesn't appear to be the case. Still, might be worth double-checking after making a release.

@fingolfin
Copy link
Member Author

Yeah I recommend we merge this & retag (will do that now) and then do one package test release to see it all works... then one by one... (possibly with dry-runs as well...)

@fingolfin fingolfin merged commit 4e39369 into main Nov 13, 2025
3 checks passed
@fingolfin fingolfin deleted the mh/makedoc-with-relativePath branch November 13, 2025 13:55
@Joseph-Edwards
Copy link
Collaborator

This looks good to me too. That said, I must admit that I'm not 100% clear where the relativePath option that we have specified actually gets used, but that's a me-problem.

@fingolfin
Copy link
Member Author

@Joseph-Edwards This option is passed on to AutoDoc which then uses it to decide on which options to pass to MakeGAPDocDoc

In other news, I tagged this, but did not yet have time to try to make a new release of anything. @stertooy or anyone else, feel free to beat me to it.

@stertooy
Copy link
Contributor

A new version of utils was released, and looking at chap 9 of its online manual, it seems the URL substitution in update-gh-pages still functions as intended. And of course the absolute paths in the actual release are also fixed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants