Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a more refined version of the two-closure computation #10

Open
wants to merge 1 commit into
base: master
from

Conversation

@JHahnHRO
Copy link

JHahnHRO commented Mar 19, 2019

The original algorithm simply intersects the automorphism groups of (almost) ALL orbital graphs. That really isn't necessary, most orbital graphs do not contribute anything new to the intersection. This new algorithm uses computations inside the endomorphism algebra of the permutation module to cut down on the number of necessary orbital graphs and should therefore be much faster.

…t does not use ALL orbital graphs.
@PaulaHaehndel

This comment has been minimized.

@markuspf

This comment has been minimized.

Copy link
Member

markuspf commented Mar 19, 2019

Did you try comparing the runtimes of this function with runtimes of the original function? What happens if you just stupidly use edge-coloured graphs?

If you do benchmarks, please provide the examples and timings.

# TODO: TwoClosure as implemented by Heiko Theißen requires the group
# to be transitive.
# to be transitive.

This comment has been minimized.

Copy link
@markuspf

This comment has been minimized.

Copy link
@JHahnHRO

JHahnHRO Mar 20, 2019

Author

No particular reason. It's just whitespace in a comment, didn't think about it much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.