Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CHANGES file date instead of build date #15

Closed
wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link
Contributor

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good

Alternative patches could use $SOURCE_DATE_EPOCH as described in
https://wiki.debian.org/ReproducibleBuilds/TimestampsProposal#Bash_.2F_POSIX_shell

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #15 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   18.08%   18.06%   -0.03%     
==========================================
  Files           4        4              
  Lines        2206     2209       +3     
==========================================
  Hits          399      399              
- Misses       1807     1810       +3
Impacted Files Coverage Δ
gap/interact.gi 14.16% <0%> (-0.04%) ⬇️
gap/general.gi 19.75% <0%> (ø) ⬆️

@fingolfin
Copy link
Member

While I do think reproducible builds are a good thing, the patch proposed here is not acceptable, nor is using SOURCE_DATE_EPOCH or any other non-portable GNU rxtensions.

However, I think we could simply stop putting the date there; seems not very useful anyway. I will look into it.

@bmwiedemann
Copy link
Contributor Author

Yes, it should work on BSD date, too - just not Solaris and the like. So dropping the date is indeed a good option. Would even simplify the overall code.

@bmwiedemann
Copy link
Contributor Author

Hi, any progress on this? Is there something I can help with? (in September after vacations)

@fingolfin
Copy link
Member

Merged #16 instead

@fingolfin fingolfin closed this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants