New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop build date from binary #16

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@bmwiedemann

bmwiedemann commented Oct 2, 2018

This simplifies the code and enables reproducible builds.
See https://reproducible-builds.org/ for why this is good.

Alternative approach is #15

This PR was done while working on reproducible builds for openSUSE.

Drop build date from binary
This simplifies the code and enables reproducible builds.
See https://reproducible-builds.org/ for why this is good.
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 2, 2018

Codecov Report

Merging #16 into master will increase coverage by 20.69%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #16       +/-   ##
===========================================
+ Coverage   18.08%   38.78%   +20.69%     
===========================================
  Files           4       10        +6     
  Lines        2206     2818      +612     
===========================================
+ Hits          399     1093      +694     
+ Misses       1807     1725       -82
Impacted Files Coverage Δ
gap/interact.gd 100% <0%> (ø)
gap/ace.gd 100% <0%> (ø)
gap/ace.gi 100% <0%> (ø)
gap/options.gd 100% <0%> (ø)
gap/general.gd 100% <0%> (ø)
gap/streams.gd 100% <0%> (ø)
gap/streams.gi 74.19% <0%> (+8.97%) ⬆️
gap/interact.gi 23.9% <0%> (+9.7%) ⬆️
gap/general.gi 31.28% <0%> (+11.52%) ⬆️
gap/options.gi 57.1% <0%> (+30.92%) ⬆️

codecov bot commented Oct 2, 2018

Codecov Report

Merging #16 into master will increase coverage by 20.69%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #16       +/-   ##
===========================================
+ Coverage   18.08%   38.78%   +20.69%     
===========================================
  Files           4       10        +6     
  Lines        2206     2818      +612     
===========================================
+ Hits          399     1093      +694     
+ Misses       1807     1725       -82
Impacted Files Coverage Δ
gap/interact.gd 100% <0%> (ø)
gap/ace.gd 100% <0%> (ø)
gap/ace.gi 100% <0%> (ø)
gap/options.gd 100% <0%> (ø)
gap/general.gd 100% <0%> (ø)
gap/streams.gd 100% <0%> (ø)
gap/streams.gi 74.19% <0%> (+8.97%) ⬆️
gap/interact.gi 23.9% <0%> (+9.7%) ⬆️
gap/general.gi 31.28% <0%> (+11.52%) ⬆️
gap/options.gi 57.1% <0%> (+30.92%) ⬆️

@alex-konovalov alex-konovalov requested a review from fingolfin Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment