Skip to content

Strengthen pipeline security with Zizmor - #3658

Merged
amolenaar merged 4 commits into
mainfrom
zizmor
Dec 15, 2024
Merged

Strengthen pipeline security with Zizmor#3658
amolenaar merged 4 commits into
mainfrom
zizmor

Conversation

@amolenaar

@amolenaar amolenaar commented Dec 13, 2024

Copy link
Copy Markdown
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

See https://blog.pypi.org/posts/2024-12-11-ultralytics-attack-analysis/

Looks like zizmor is the go-to tool.

Your composite actions (action.yml) files are not checked. It's on zizmor's backlog, though: zizmorcore/zizmor#173.

The most common issue found are template injection, and artipacked.

In the labeler workflow we use a dangerous trigger. Should we delete this workflow and set labels ourselves again?

error[dangerous-triggers]: use of fundamentally insecure workflow trigger
 --> /Users/arjan/Development/gaphor/.github/workflows/labeler.yml:2:1
  |
2 | / on:
3 | | - pull_request_target
  | |_____________________^ pull_request_target is almost always used insecurely
  |
  = note: audit confidence → Medium

@amolenaar
amolenaar force-pushed the zizmor branch 3 times, most recently from 7051465 to 79d49a1 Compare December 13, 2024 09:34
@amolenaar
amolenaar merged commit ed3a6d1 into main Dec 15, 2024
@amolenaar
amolenaar deleted the zizmor branch December 15, 2024 18:18
@amolenaar amolenaar added the chore Maintenance related PR label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant