From 74d794a5c2ebffd8527067677881dde5446739c0 Mon Sep 17 00:00:00 2001 From: ggwadera <16023489+ggwadera@users.noreply.github.com> Date: Thu, 10 Sep 2020 22:31:15 -0300 Subject: [PATCH 1/2] docker: change command to use npm Executing directly with node didn't allow to run additional commands like compiling for example. --- src/helpers/docker.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/helpers/docker.ts b/src/helpers/docker.ts index d48fc71..6113729 100644 --- a/src/helpers/docker.ts +++ b/src/helpers/docker.ts @@ -66,7 +66,7 @@ const createContainer = async ( ] } }, - Cmd: ['node', '.'] + Cmd: ['npm', 'run', 'start'] }) .then(container => container.id) .catch(err => err) From 2ebce08cb68b062e6b3f72714bcac61fb86c5e0d Mon Sep 17 00:00:00 2001 From: ggwadera <16023489+ggwadera@users.noreply.github.com> Date: Thu, 10 Sep 2020 22:36:33 -0300 Subject: [PATCH 2/2] update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3cbdf52..137c445 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ app.get('/', (req, res) => { app.listen(process.env.PORT || 8123); ``` -7. Update the `main` field in `package.json` with the filename of your app entry point: `"main": "app.js"` +7. Update the `scripts` section in `package.json` with your app entry point command, under `start`: `"start": "node app.js"` 8. Run `git add .` 9. Run `git commit -m "Initial Commit"` 10. Run `git push origin master`