Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RetroPlayer] Adjust game loop #99

Merged
merged 1 commit into from Jun 13, 2018

Conversation

@GTechAlpha
Copy link

GTechAlpha commented Jun 12, 2018

Description

Accounts for sporadic variations and prevents indefinite catch-up.

Motivation and Context

Discovered inconsistent and undesired timing during testing.

How Has This Been Tested?

PCSX, GenesisPlus, Nestopia

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@GTechAlpha GTechAlpha mentioned this pull request Jun 12, 2018
1 of 4 tasks complete
@GTechAlpha GTechAlpha changed the title [RetroPlayer] adjust game loop [RetroPlayer] Adjust game loop Jun 12, 2018
@garbear garbear force-pushed the garbear:retroplayer-18alpha2 branch 2 times, most recently from 6a15d41 to 2908c0d Jun 12, 2018
m_adjustTime = 0.0;
}

CLog::Log(LOGDEBUG, "[RetroPlayer][GameLoop] adjust time = %0.4f", m_adjustTime);

This comment has been minimized.

Copy link
@garbear

garbear Jun 12, 2018

Owner

We should avoid logging for every frame before this hits master

This comment has been minimized.

Copy link
@GTechAlpha

GTechAlpha Jun 13, 2018

Author

Agreed. Intended to remove this.

@garbear

This comment has been minimized.

Copy link
Owner

garbear commented Jun 12, 2018

The new timing looks good. I tested and gameplay was smooth. I didn't notice the glitches on my i7, but I haven't tested on embedded in a while.

@garbear garbear force-pushed the garbear:retroplayer-18alpha2 branch from 2908c0d to 2cc5ded Jun 12, 2018
@GTechAlpha

This comment has been minimized.

Copy link
Author

GTechAlpha commented Jun 13, 2018

Updated. Should be good to go.

@garbear garbear merged commit feb75ff into garbear:retroplayer-18alpha2 Jun 13, 2018
@GTechAlpha GTechAlpha deleted the GTechAlpha:gb_pr_gameloop_18a2 branch Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.