Skip to content

Commit

Permalink
fix(core): error in actions.getStatus helper
Browse files Browse the repository at this point in the history
Occurred only when services depended on tasks, so it was missed
in testing.
  • Loading branch information
edvald committed Feb 5, 2019
1 parent 0831730 commit a4cf625
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions garden-service/src/actions.ts
Expand Up @@ -71,11 +71,7 @@ import {
RunTaskParams,
TaskActionParams,
} from "./types/plugin/params"
import {
Service,
ServiceStatus,
prepareRuntimeContext,
} from "./types/service"
import { Service, ServiceStatus, getServiceRuntimeContext } from "./types/service"
import { mapValues, values, keyBy, omit, pickBy, fromPairs } from "lodash"
import { Omit } from "./util/util"
import { processServices, ProcessResults } from "./process"
Expand Down Expand Up @@ -344,8 +340,7 @@ export class ActionHelper implements TypeGuard {
const services = keyBy(await graph.getServices(), "name")

const serviceStatus = await Bluebird.props(mapValues(services, async (service: Service) => {
const serviceDependencies = await graph.getServices(service.config.dependencies)
const runtimeContext = await prepareRuntimeContext(this.garden, graph, service.module, serviceDependencies)
const runtimeContext = await getServiceRuntimeContext(this.garden, graph, service)
// TODO: The status will be reported as "outdated" if the service was deployed with hot-reloading enabled.
// Once hot-reloading is a toggle, as opposed to an API/CLI flag, we can resolve that issue.
return this.getServiceStatus({ log, service, runtimeContext, hotReload: false })
Expand Down

0 comments on commit a4cf625

Please sign in to comment.