Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror examples to separate repo #128

Closed
edvald opened this issue May 30, 2018 · 8 comments
Closed

Mirror examples to separate repo #128

edvald opened this issue May 30, 2018 · 8 comments
Assignees

Comments

@edvald
Copy link
Collaborator

edvald commented May 30, 2018

It would be cleaner to have all the examples (and there should be many more over time) to a separate repo. We'd need to stop using the hello-world as part of our tests, but we want to do that anyway.

@edvald
Copy link
Collaborator Author

edvald commented Jun 20, 2018

Actually, we may want to keep them in the same repo if we go for #171 ?

@eysi09
Copy link
Collaborator

eysi09 commented Jul 2, 2018

Would be nice to be able to git clone the examples separately though.

@eysi09
Copy link
Collaborator

eysi09 commented Jul 3, 2018

There's actually already an examples repo: https://github.com/garden-io/garden-examples

Wasn't the plan to maintain those examples separately and have other examples within the project that would function more as integration test?

@edvald
Copy link
Collaborator Author

edvald commented Jul 3, 2018

Yeah, I just kept the issue open (also because of the question above, which was just a thought) because we still have the examples in this repo. We should at least move them to the test/integ directory then to be sure not to cause confusion, and maybe just fold the features we want to integration test into a single project.

One issue with having the examples in a separate repo, is that we don't run any tests there, and don't pin the examples to a particular version of garden-cli. I've already seen cases where the examples have broken, and if we want to keep them separate we need to add some setup to automatically test them. Otherwise they'll inevitably drift, especially as our APIs are still changing fairly often.

@vkorbes
Copy link
Contributor

vkorbes commented Sep 21, 2018

I propose we should keep the examples in the main repo, and then have them mirrored to a separate examples repo.

This way it's easier for us to commit changes to the code functionality and the respective adjustments to the examples in one single PR, for example, but we still have a separate and much lighter/smaller repo of examples only that we can use for didactic reasons.

Thoughts?

@thsig
Copy link
Collaborator

thsig commented Sep 21, 2018

Ellen and I talked about this earlier — just to clarify, mirroring = running a script that automatically updates the examples repo with changes to example projects in the main repo.

That way, example projects are still maintained/developed as part of the main dev/test/release workflows.

@edvald
Copy link
Collaborator Author

edvald commented Sep 21, 2018

Good idea! We could rig that up via Github hooks on master.

@edvald edvald changed the title Move examples to separate repo Mirror examples to separate repo Sep 24, 2018
@eysi09
Copy link
Collaborator

eysi09 commented Sep 23, 2019

I'm going to close this one since we have some other thoughts on how to maintain the examples as well, e.g. as submodules in the main project.

@eysi09 eysi09 closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants