-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror examples to separate repo #128
Comments
Actually, we may want to keep them in the same repo if we go for #171 ? |
Would be nice to be able to git clone the examples separately though. |
There's actually already an examples repo: https://github.com/garden-io/garden-examples Wasn't the plan to maintain those examples separately and have other examples within the project that would function more as integration test? |
Yeah, I just kept the issue open (also because of the question above, which was just a thought) because we still have the examples in this repo. We should at least move them to the One issue with having the examples in a separate repo, is that we don't run any tests there, and don't pin the examples to a particular version of |
I propose we should keep the examples in the main repo, and then have them mirrored to a separate examples repo. This way it's easier for us to commit changes to the code functionality and the respective adjustments to the examples in one single PR, for example, but we still have a separate and much lighter/smaller repo of examples only that we can use for didactic reasons. Thoughts? |
Ellen and I talked about this earlier — just to clarify, mirroring = running a script that automatically updates the examples repo with changes to example projects in the main repo. That way, example projects are still maintained/developed as part of the main dev/test/release workflows. |
Good idea! We could rig that up via Github hooks on master. |
I'm going to close this one since we have some other thoughts on how to maintain the examples as well, e.g. as submodules in the main project. |
It would be cleaner to have all the examples (and there should be many more over time) to a separate repo. We'd need to stop using the hello-world as part of our tests, but we want to do that anyway.
The text was updated successfully, but these errors were encountered: