improvement(core): log stderr from exec as info #5227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, we logged stderr streams from init scripts as errors but now we log it at the info level. The reason is that some tools, e.g. gcloud, write to stderr even if it's not an actual error. In the case of an actual error the script exits with a non-zero code and that's handled specifically. So this is really just a cosmetic change to how exec provider logs are rendered.
mkhq
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this change, we logged stderr streams from
init scripts as errors but now we log it at the info level.
The reason is that some tools, e.g. gcloud, write to stderr even if it's
not an actual error.
In the case of an actual error the script exits with a non-zero
code and that's handled specifically.
So this is really just a cosmetic change to how exec provider logs are
rendered.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: