improvement: add additional info to error message when sh is not found #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
approved these changes
Mar 22, 2023
|
Thank you! 👍 |
vvagaytsev
requested changes
Mar 22, 2023
vvagaytsev
force-pushed
the
improve-error-message-when-sh-not-found
branch
from
3e98e33
to
e90aefe
Compare
|
I've fixed the test assertions, let's wait for the test results. |
vvagaytsev
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A user is having intermittent errors when running a test with artifacts where Garden responds with the error message:
They are sure that both
shandtarare present in the container.Given the way we determine if
shortarare not present and the difficulty in reproducing the error, I propose to print the full error message we receive from the execution, in the hope we can identify the root cause.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: