Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task-graph): use latest version for dedup #958

Merged
merged 1 commit into from Jul 11, 2019

Conversation

thsig
Copy link
Collaborator

@thsig thsig commented Jul 11, 2019

Before this fix, the first task to become pending for a given key was the one chosen by the deduplication process, instead of the last added task.

Now, when a task is added and there's already a pending task with the same key, the previously pending task is effectively replaced with the new task, ensuring that the last added task is the one that gets processed.

Before this fix, the first task to become pending for a given key was
the one chosen by the deduplication process, instead of the last added
task.

Now, when a task is added and there's already a pending task with the
same key, the previously pending task is effectively replaced with the
new task, ensuring that the last added task is the one that gets
processed.
Copy link
Collaborator

@eysi09 eysi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise.

@eysi09 eysi09 merged commit 7efea23 into master Jul 11, 2019
@edvald edvald deleted the pending-task-version-fix branch July 31, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants