Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Navigation State after Login #329

Closed
grolu opened this issue Mar 14, 2019 · 0 comments · Fixed by #328
Closed

Retain Navigation State after Login #329

grolu opened this issue Mar 14, 2019 · 0 comments · Fixed by #328
Assignees
Labels
area/usability Usability related component/dashboard Gardener Dashboard effort/2w Effort for issue is around 2 weeks exp/intermediate Issue that requires some project experience kind/discussion Discussion (enaging others in deciding about multiple options) kind/enhancement Enhancement, improvement, extension

Comments

@grolu
Copy link
Contributor

grolu commented Mar 14, 2019

We keep most of the navigation state in the URL (including pages and tabs, but currently excluding dialogs and form data). This way, it is possible to send e.g. links, that point to a specific cluster of the gardener Dashboard.
However, if the user that opens the URL is currently not logged in to the dashboard, he is redirected to the login page and looses navigation information: After successful authentication, the user is redirected to the start page (which is - for most cases - the cluster overview).
We need to improve here, especially as this issue will increase after #328 gets merged. This PR will significantly reduce the token lifetime and lead to more authentication and redirects to the start page.
Moreover, we should discuss if we want to include more information (about open dialogs, unsent form input, etc.) into the URL, or store it in local browser store.

@grolu grolu added kind/enhancement Enhancement, improvement, extension exp/intermediate Issue that requires some project experience size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) component/dashboard Gardener Dashboard kind/discussion Discussion (enaging others in deciding about multiple options) area/usability Usability related labels Mar 14, 2019
@grolu grolu closed this as completed Apr 2, 2019
@grolu grolu reopened this Apr 2, 2019
@gardener-robot gardener-robot added effort/2w Effort for issue is around 2 weeks and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related component/dashboard Gardener Dashboard effort/2w Effort for issue is around 2 weeks exp/intermediate Issue that requires some project experience kind/discussion Discussion (enaging others in deciding about multiple options) kind/enhancement Enhancement, improvement, extension
Projects
None yet
3 participants