Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OIDC provider that does not allow CORS on the metadata endpoint #270

Merged
merged 1 commit into from Jan 11, 2019

Conversation

holgerkoser
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
If an OIDC provider does not allow CORS on the metadata endpoint, it should be possible to manually configure the oidc-client with these additional settings.
oidc-client docs
This PR allows to configure these settings in the helm chart. It also proxies the jwks endpoint of the oidc provider if oidc.metadata.jwks_uri === '/keys'

Release note:

Support for OIDC provider that does not allow CORS on the metadata endpoint

Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holgerkoser holgerkoser merged commit 5f9b75d into master Jan 11, 2019
@holgerkoser holgerkoser deleted the cors branch January 16, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants