Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max-backups configurable in LimitBased GC from Etcd CR #754

Closed
anveshreddy18 opened this issue Jan 11, 2024 · 0 comments · Fixed by #755
Closed

Make max-backups configurable in LimitBased GC from Etcd CR #754

anveshreddy18 opened this issue Jan 11, 2024 · 0 comments · Fixed by #755
Assignees
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Milestone

Comments

@anveshreddy18
Copy link
Contributor

Feature (What you would like to be added):
Add maxBackupsLimitBased field to the spec.backup section of Etcd yaml.

Motivation (Why is this needed?):

  • At present, there is no way to configure the number of full snapshots to retain in a limitBased GC policy as a default value of 7 is set in the code.
  • This change will allow the user to configure the --max-backups flag of the etcd-statefulset thus allowing them to control the behaviour of Limit Based GC.

Note: It will be an optional field, when not set, max-backups will be defaulted to 7

Approach/Hint to the implement solution (optional):

Add the maxBackupsLimitBased field to the spec.backup section of Etcd yaml, and define the MaxBackupsLimitBased field in the BackupSpec struct of Etcd CRD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
3 participants