Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network policies are created last #1090

Merged
merged 1 commit into from Jun 12, 2019

Conversation

@mvladev
Copy link
Member

commented Jun 12, 2019

What this PR does / why we need it:

This is a temporary fix to enable smooth migration to the new NetPolicies for StatefulSets.
New network policies are applied for existing workload and Statefulsets might break and leave the Pods crashing indefinitely kubernetes/kubernetes#67250

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE
Network policies are installed last
This is a temporary fix to enable smooth migration to the new
NetPolicies for StatefulSets.
@rfranzke
Copy link
Member

left a comment

/lgtm

Thank you!

@mvladev

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

The policies are now deplyoed after SeedMonitoring, SeedLogging and ClusterAutoscaler.

This should be sufficient, right?

@rfranzke

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Yes, it's correct. Thanks!

@rfranzke rfranzke merged commit ca5b887 into gardener:master Jun 12, 2019

4 checks passed

concourse-ci/check Concourse CI build success
Details
concourse-ci/publish Concourse CI build success
Details
concourse-ci/test Concourse CI build success
Details
license/cla Contributor License Agreement is signed.
Details

@mvladev mvladev deleted the mvladev:fix-network-policies-order branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.