Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added OpenStack LoadBalancer classes support #1111

Conversation

Projects
None yet
3 participants
@afritzler
Copy link
Member

commented Jun 18, 2019

Co-authored-by: Uwe Krueger uwe.krueger@sap.com

What this PR does / why we need it:
In order to incorporate the support of LoadBalancer classes of the out-of-tree cloud provider for OpenStack (kubernetes/cloud-provider-openstack#619), this PR allows you to configure the corresponding LB classes via the CloudProfile and Shoot spec.

Special notes for your reviewer:
This is currently a WIP. Since official cloud provider image has not been released yet, we will test it first with a local build version for now.

Release note:

Added LoadBalancer classes support for OpenStack

@afritzler afritzler requested a review from gardener/gardener-maintainers as a code owner Jun 18, 2019

@afritzler

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

Validation tests are still missing.

Added loadbalancer classes support
Co-authored-by: Uwe Krueger <uwe.krueger@sap.com>

@afritzler afritzler force-pushed the afritzler:feature.added_support_openstack_lbaas_classes branch from 50f39bb to 0c593d2 Jun 18, 2019

@rfranzke

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

We will hopefully merge #1076 soon. It doesn't make sense to merge this one now because it would postpone #1076 and produce additional effort for the colleagues that are implementing the OpenStack extension controller.

Can you open a PR against the gardener-extensions repo and do these adaptions in the OpenStack controller?

Can you adapt this PR to only include the API changes that are required in the CloudProfile and Shoot?

Thank you!

@afritzler

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

I guess you are referring to #1076. Agreed that would make things worse. Then we will shrink this PR to just the spec changes in the CloudProfile and Shoot.

@afritzler afritzler closed this Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.