Skip to content

Improve availability of oidc-federation-service#8

Open
Michael5601 wants to merge 9 commits into
mainfrom
oidc-federation-high-availability
Open

Improve availability of oidc-federation-service#8
Michael5601 wants to merge 9 commits into
mainfrom
oidc-federation-high-availability

Conversation

@Michael5601

@Michael5601 Michael5601 commented Jun 5, 2026

Copy link
Copy Markdown

This draft PR improves the availability of the oidc-federation-service by changing the following:

  1. Increase replicas from 1 to 5
  2. Add a VPA to increase resource request on demand
  3. Spread replicas across multiple zones

Active-Active is possible for the oidc-federation-service as the only limiting factor is the Github REST API rate limit, which is sufficient for 5 replicas. We call the API in token_exchange.py for the following:

  1. JWKS keys — at most 5 fetches per 24h per issuer.
  2. oidc-federation.yaml — at most 5×4 = 20 fetches/hour per org.
  3. Installation IDs — 5 fetches total at pod startup, then cached forever.
  4. Token request — this is one call per incoming request regardless of replica count, so replicas don't change anything here.

Release note:

NONE

@gardener-prow gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@gardener-prow

gardener-prow Bot commented Jun 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zkdev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 5, 2026
@CLAassistant

CLAassistant commented Jun 5, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gardener-prow gardener-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Jun 5, 2026

@TuanAnh17N TuanAnh17N left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progress! :)

@gardener-prow gardener-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2026
@Michael5601 Michael5601 force-pushed the oidc-federation-high-availability branch from ba207d8 to 86182dd Compare June 8, 2026 08:24
@Michael5601 Michael5601 self-assigned this Jun 8, 2026
@Michael5601 Michael5601 marked this pull request as ready for review June 8, 2026 08:25
@gardener-prow gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2026
@Michael5601 Michael5601 requested a review from TuanAnh17N June 8, 2026 08:26
Comment thread charts/github-oidc-federation/templates/deployment.yaml Outdated
Comment thread charts/github-oidc-federation/templates/hpa.yaml Outdated
Comment thread charts/github-oidc-federation/templates/network_policies.yaml
Comment thread charts/github-oidc-federation/values.yaml Outdated
Comment thread charts/github-oidc-federation/templates/network_policies.yaml
@gardener-prow gardener-prow Bot removed the cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. label Jun 8, 2026
@gardener-prow gardener-prow Bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants