Gareth Rees garethrees

Organizations

@mysociety @cardiffrb
garethrees commented on pull request mysociety/alaveteli#2611
@garethrees

For reference, here are all the button states: <!-- track: subscribing to emails --> <!-- vote: simply increments the vote count. No subscription -->

@garethrees

Marking as current sprint as I keep going to review this then realising we can't yet. mysociety/alaveteli#2263

@garethrees

Hi @petterreinholdtsen, https://alaveteli-dev.nuug.no/en/body now seems to be doing the correct thing. Did you make any changes to get this to work?

garethrees commented on pull request mysociety/alaveteli#2619
@garethrees

https://alaveteli-dev.nuug.no/en/body now seems to be doing the correct thing – following up in #2482

garethrees commented on pull request mysociety/alaveteli#2611
@garethrees

Added #2611 (commits) for review

@garethrees

I've thought about this a bit and I still maintain this is clearer. Note that it also breaks the AskTheEU pull request Only a URL change so not t…

garethrees commented on pull request mysociety/asktheeu-theme#2
@garethrees

Although it has it's own stylesheet rather than including the main scss in order to make it more lightweight on other sites. We do that in core too

garethrees commented on pull request mysociety/asktheeu-theme#2
@garethrees

I think we need to re-review this after mysociety/alaveteli#2263 is merged. Looks like the widget show template does a lot that will be available i…

@garethrees
Improve 500 error page
@garethrees
@garethrees
@garethrees
Blue favicon
@garethrees

This is wrong. Doing this renders the "You have voted on this request" if a cookie exists for any request. What we actually want is: @tracking_cookie

@garethrees

:+1:, but need to think of shorter wording :(

@garethrees

:crown:

@garethrees

:gb: :gb: :gb: :gb: :gb: :gb: :gb:

@garethrees

Could extract the two component bits out in to mixins (or whichever is the one you call extend on!) .expand_links { // ... } controller_help { @ex…

@garethrees

I think its pretty conventional to use US-English for programming. I can't say I've never written UK English, but when mapping something like $colo…

@garethrees

Yeah, its CSS.

@garethrees
Add spec to check that images have been compressed
@garethrees

That would be an awesome check to have. We don't actually run CI on themes (mysociety/alaveteli#1853) but might still be worth adding to alaveteli …

@garethrees
Reduce number of page links shown when page count is high
@garethrees

Yep, if it works we should look into it - something for Alaveteli core though? Yeah too much of a faff to override here.

@garethrees

For future reference: https://github.com/emcien/iso_latte might be useful in this area.

@garethrees

Bah just merged this but noticed the file size has doubled! assets/images/navimg/logo-trans-small.png | Bin 4505 -> 9644 bytes @wrightmartin anyth…

@garethrees

Looks great – just some minor tidy-up. :+1:

@garethrees

.correspondence is already used on L73. This looks like the right place for it.

@garethrees

Delete if we're not going to style it

@garethrees

.incoming.correspondence is already defined on L161