Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses camlp4 #1

Closed
glondu opened this issue Aug 3, 2019 · 4 comments

Comments

@glondu
Copy link

commented Aug 3, 2019

As written here, camlp4 is deprecated and might never be updated for OCaml 4.08.0. Please consider using camlp5 or a ppx instead.

@XVilka

This comment has been minimized.

Copy link

commented Aug 7, 2019

It is used for parsing mainly - so it is easier to switch to sedlex or mehrir instead, only two very small files are affected, so the change is trivial:

@garrigue

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2019

While the problem is indeed simple in lablGL, as the parsers are very simple, the situation is more difficult with LablGtk, which uses a much more complex parser using stream parser.

A temporary solution is to switch to camlp5, as the stream parser syntax should be compatible.
In the long run, the question is whether there is any plan support stream parsers again in vanilla ocaml.

@garrigue

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2019

Fixed in new release LablGL 1.06. The dependency now only exists only during development, and camlp5 can be used as replacement.

@garrigue

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

Fixed in d0fd3cb.
The only remaining dependency is on https://github.com/camlp5/camlp5, for developers of lablGL itself (the processed file is in the repository).

@garrigue garrigue closed this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.