Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jpg support. #383

Merged
merged 1 commit into from Jan 25, 2017
Merged

added jpg support. #383

merged 1 commit into from Jan 25, 2017

Conversation

mirzazeyrek
Copy link
Contributor

For saving bandwidth and space especially with huge test cases and CI tool integrations.

screenshot_80

added suggested changes from @garris

@garris garris merged commit ccba326 into garris:beta Jan 25, 2017
@garris
Copy link
Owner

garris commented Jan 25, 2017

Will push this to npm today.

garris pushed a commit that referenced this pull request Feb 3, 2017
@marc0n3
Copy link

marc0n3 commented Jun 13, 2017

Is jpg compression level selectable somewhere?
Thanks in advance

@mirzazeyrek
Copy link
Contributor Author

Hi @marc0n3 ,

Yes but not via config file unfortunately. There are some changes since my jpeg PR but changing 85 in getDiffImageAsJPEG method should work:

https://github.com/garris/BackstopJS/blob/master/core/util/compare/store-failed-diff.js#L20

mirzazeyrek added a commit to mirzazeyrek/BackstopJS that referenced this pull request Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants