feat: output dir config & remove dep on pkg 'main' #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garronej
reviewed
Aug 29, 2021
| @@ -12,6 +12,7 @@ commanderStatic | |||
| `) | |||
| .option("-p, --project [projectPath]", `Default: './' -- Root path of the project to denoify, target directory is supposed to contain a 'package.json' and 'tsconfig.json'.`) | |||
| .option("--src [srcDirPath]", `Default: '[projectPath]/src' | '[projectPath]/lib' -- Path to the directory containing the source .ts files. If the provided path is not absolute it is assumed relative to [projectPath]`) | |||
| .option("--out [outputDirPath]", `Default: '$(dirname <tsconfig.outDir>)/deno_lib' -- Path to the output directory`) | |||
Comment on lines
-61
to
-77
| if (!("main" in packageJsonParsed)) { | ||
| //TODO: We shouldn't force users to specify a default export. | ||
| throw new Error([ | ||
| "A main field in package.json need to be specified", | ||
| "otherwise we don't know what file the mod.ts should export." | ||
| ].join(" ")); | ||
| } | ||
|
|
||
| if ( | ||
| !isInsideOrIsDir({ | ||
| "dirPath": tsconfigOutDir, | ||
| "fileOrDirPath": path.normalize(packageJsonParsed["main"]) | ||
| }) | ||
| ) { | ||
| throw new Error(`The package.json main should point to a file inside ${tsconfigOutDir}`) | ||
| } | ||
|
|
There was a problem hiding this comment.
I no longer have all the context in mind to remember why I deemed important to have this fail early strategy here.
I am willing to trust you on the fact that it can be safely removed.
|
I just released a new version featuring your changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod.tscannot be generated. Currentlydenoifyrequires that package.jsonmainshould be insidetsconfig.outDir. It causesdenoifycannot work on some projects and there is no workaround.