DCollapsibleCategory fixes #1007

merged 3 commits into from May 13, 2016


None yet

4 participants

Bo98 commented Jul 6, 2015
  • Fixed DCollapsibleCategory not expanding to correct height when using cat:SetContents.
  • Fixed DCollapsibleCategory header height decreasing on animation (should have remained constant).
  • Added DCategoryList example for the derma_controls concommand.
  • Renamed dcategorycollapse.lua to dcollapsiblecategory.lua.
  • Lowercased file names in vgui_base.lua.

How many times do I have to ask people not to include any whitespace changes? It makes it that much harder to find the actual changed code.

Bo98 commented Jul 6, 2015

My editor does it automatically.

You should really clean it all up sometime across the repo.

I can revert the whitespace changes if you want or you can view the diff without the whitespace changes (?w=1) if it's just because it's hard to find changes.

willox commented Jul 7, 2015

You should add in a single line with 1MB of whitespace

@robotboy655 robotboy655 merged commit c3b672f into garrynewman:master May 13, 2016
@Bo98 Bo98 deleted the Bo98:dcollapsiblecategory-fixes branch May 13, 2016
@robotboy655 robotboy655 added a commit that referenced this pull request May 13, 2016
@robotboy655 robotboy655 Fixed PR #1007
In addition to spacing changes, fixed a case where OldHeight would be
overridden to an incorrect value if SetExpanded was called while the
animation was going ( i.e. while the height of the panel was not what it
should be for self.OldHeight purpose )

Added IsValid() checks for self.Contents, and fixed an animation bug
when in spawnmenu opening the tool categories after first opening the
spawnemenu with saved closed categories would make the animation expand
to a wrong value.

I still hate this panel very much, and none of these patches with #1007
and this one make it perfect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment