Replace loads of if with ternary #1107

Merged
merged 1 commit into from Jan 11, 2016

Projects

None yet

3 participants

@Kngrektor
Contributor

No description provided.

@bmwalters
Contributor

this block would also be improved by splitting the string into a table of substrings instead of :find()ing each possible choice. the wiki already tells devs to separate the terms with a space, so it shouldn't break anything.

@Kngrektor
Contributor

I though of doing a map / dictionary like table but didnt because it felt
unnecessary, but i guess thats what the devs thought when they did the if
statements.

On Sun, Jan 3, 2016 at 10:31 PM, Zerf notifications@github.com wrote:

this block would also be improved by splitting the string into a table of
substrings instead of :find()ing each possible choice. the wiki already
tells users to separate the terms with a space, so it shouldn't break
anything.


Reply to this email directly or view it on GitHub
#1107 (comment)
.

@robotboy655 robotboy655 merged commit cbd5de1 into garrynewman:master Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment