Replace deprecated function calls with non-deprecated alternatives #1162

merged 1 commit into from Apr 22, 2016


None yet

2 participants

bmwalters commented Apr 22, 2016 edited

In this PR I shift usage of deprecated functions in the codebase to their recommended alternatives.
This is an update of #1102.

  • I kept duplicate accessors (both Set/GetDrawBackground and Set/GetPaintBackground) in panels for compatibility. I also did not alter the internal names of the accessors.
  • I did not touch spawnmenu.PopulateFromEngineTextFiles and spawnmenu.DoSaveToTextFiles because using only their base functions breaks things.
  • I left the only ProtectedCall call anywhere in the codebase alone, as I have been informed that it is not just an alias. Replacing it with pcall seems to not break anything, but I left it just in case.
@robotboy655 robotboy655 merged commit b9e5a71 into garrynewman:master Apr 22, 2016
@robotboy655 robotboy655 added a commit that referenced this pull request Apr 22, 2016
@robotboy655 robotboy655 Fixed PR #1162 2ea8e0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment