Slight optimization to this function which is called very frequently. I recorded 25% speed increase. If the math functions were made local then it would be a 40% speed increase.
Optimization to frequently called math function
this isn't even an optimization - it completely changes how it works
No it doesn't. Explain what makes you think that.
You and robotboy need to practice your math skills.
It does. For example, math.Approach( 100, 101, -50 ). Before, that would return 100, but it would return 50 with your change. I know it's a bit illogical to use math.Approach that way in the first place, but it was a previous behaviour.
Oh, damn. @thegrb93 is right
It's not about math skills, its about the one line GitHub chose to omit.